fix: make SKIP_UTILS correctly filter hashsum utilities #8696
Conversation
Completely replace the old install logic with new logic that: 1. Gets all available utilities from coreutils --list 2. Properly filters against SKIP_UTILS using grep -qw 3. Provides informative messages during installation 4. Handles both hashsum and regular utilities correctly Fixes issue uutils#8654 where hashsum utilities were not being skipped during installation despite being specified in SKIP_UTILS. Testing verified: - sha3-224sum and sha3-256sum are correctly skipped - Other hashsum utilities are correctly installed - Regular utilities continue to work normally - Multiple skip patterns work correctly - Edge cases (empty skip, non-existent utilities) handled properly
|
I think filterling symlink is not a solution if binary size is kept. |
What do you propose as a different solution and I will make changes? Thank you for the feedback. Appreciate it. |
|
Maybe, this is more complex issue and should be solved at same time with solving #4414 |
Thank you, brother. I will research deeply into this issue then and the one you referenced me throughout the week. 🙂 |
|
GNU testsuite comparison: |
|
I don't know how many people needs small indivisual (non-multicall) binaries. But I think hasusums are treated as same as other commands. |
I saw someone mentioned an issue to remove multicall as a whole, so should I focus on this issue first then move on to this one? 🙂 |
|
I changed my mind. This may still useful to solve packaging issue. And I want to open a simpler PR replacing this, with another fixes. OK? |
Sure, be my guest. I just wanted to contribute something useful to this project and be useful.. 😅 Let me know if you still need help. I am available this weekend and next to fix some issues. 🙂 |
2 participants
Fixes #8654
Description
SKIP_UTILS does not skip part of hashsum
Problem
The make install SKIP_UTILS="sha3-224sum sha3-256sum ..." command was not properly skipping hashsum utilities during installation, which was a barrier to packaging uutils as a drop-in replacement for coreutils.
Root Cause
The install logic only filtered from the INSTALLEES list, but hashsum utilities are provided by the multicall binary and needed to be filtered from the full utility list obtained via coreutils --list.
Solution
Replaced the old foreach loop with new logic that:
Testing
Verified the fix works correctly with:
Changes Made
Closes #8654